Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to execute start on TimeRanges #71

Merged
merged 2 commits into from
Apr 17, 2019
Merged

fix: failed to execute start on TimeRanges #71

merged 2 commits into from
Apr 17, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 17, 2019 •
edited
Loading

fix: failed to execute start on TimeRanges

Description

Use buffered .start when buffered.length is not empty

  • Fix: Failed to execute 'start' on 'TimeRanges': The index provided (0) is greater than or equal to the maximum bound (0)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 17, 2019
@codecov-io
Copy link

codecov-io commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #71 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
- Coverage   51.53%   51.5%   -0.03%     
=========================================
  Files         123     123              
  Lines        1721    1722       +1     
=========================================
  Hits          887     887              
- Misses        834     835       +1
Impacted Files Coverage Δ
packages/griffith-mp4/src/player.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3702079...dd05971. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit b59c4d0 into zhihu:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyuhen @codecov-io